Fix LogLevel: CLI phase suppression and case-insensitive "Default" config key by Copilot · Pull Request #3203 · Azure/data-api-builder

Copilot · 2026-03-07T00:57:03Z

Why make this change?

[Bug]: LogLevel incorrect behavior and failing #3201
Two LogLevel bugs: Using the None LogLevel still emits some Information messages (version, config path, etc.), and using "Default" (capital D) as a key in telemetry.log-level config crashes startup with NotSupportedException.

What is this change?

All logs follow the LogLevel configuration

Added more specific configuration for logs in the host level, Program.cs which where outputing some logs that where not following the LogLevel configuration from CLI and from configuration file.
Add DynamicLogLevelProvider class which allows the loggers in the host level to be updated after the RuntimeConfig is parsed and we know the LogLevel.
Add StartupLogBuffer class which saves the logs that are created before we know the LogLevel, and sends them to their respective logger after the RuntimeConfig is parsed.

Case-insensitive "Default" key in config

IsLoggerFilterValid used string.Equals (ordinal), so "Default" failed against the registered "default" filter.
GetConfiguredLogLevel used TryGetValue("default") (case-sensitive), silently ignoring "Default" keys.
Both fixed with StringComparison.OrdinalIgnoreCase / LINQ FirstOrDefault.

// Now works — previously threw NotSupportedException
"telemetry": {
  "log-level": {
    "Default": "warning"
  }
}

# Now silent — previously emitted "Information: Microsoft.DataApiBuilder ..."
dab start --LogLevel None

How was this tested?

Integration Tests
Unit Tests
- ValidStringLogLevelFilters: added "Default" (capital D) data row to cover the case-insensitive validation fix.

Sample Request(s)

# Suppress all output
dab start --LogLevel None

# Config key now case-insensitive
# dab-config.json:
# "telemetry": { "log-level": { "Default": "none" } }
dab start

…ive Default key Co-authored-by: RubenCerna2079 <32799214+RubenCerna2079@users.noreply.github.com>

RubenCerna2079 · 2026-03-12T00:24:42Z

/azp run

azure-pipelines · 2026-03-12T00:25:05Z

Azure Pipelines successfully started running 6 pipeline(s).

Copilot

Pull request overview

Addresses two logging-related startup issues: (1) honoring --LogLevel during early/CLI-phase output, and (2) treating the telemetry.log-level config key "default" case-insensitively so "Default" doesn’t crash startup.

Changes:

Updates runtime-config log-level validation and lookup to be case-insensitive for "default"/"Default".
Refactors service startup/config-loader logging to route messages through logging infrastructure (with buffering intended before final log level is known).
Adjusts CLI E2E tests around --LogLevel behavior, splitting Information-and-below vs Warning-and-above scenarios.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/Service/Startup.cs	Adds log buffering + runtime log-level update wiring during startup (and config-loader logger wiring).
src/Service/Program.cs	Adds dynamic filtering hooks intended to suppress early messages based on effective log level.
src/Config/FileSystemRuntimeConfigLoader.cs	Replaces direct console writes with logger/buffered logging and adds logger setter/flush.
src/Config/ObjectModel/RuntimeConfig.cs	Makes `"default"` log-level lookup case-insensitive in `GetConfiguredLogLevel`.
src/Core/Configurations/RuntimeConfigValidator.cs	Makes logger-filter validation case-insensitive.
src/Service.Tests/Configuration/ConfigurationTests.cs	Adds a test row covering `"Default"` log-level key validation.
src/Cli/Program.cs	Keeps CLI logger factory usage and loader creation (but currently still doesn’t wire args into log level).
src/Cli.Tests/EndToEndTests.cs	Updates E2E coverage for `--LogLevel` expectations and adds a Warning+ startup test.

You can also share your feedback on Copilot code review. Take the survey.

src/Service/Program.cs

src/Config/FileSystemRuntimeConfigLoader.cs

src/Config/ObjectModel/RuntimeConfig.cs

src/Service/Startup.cs

src/Config/FileSystemRuntimeConfigLoader.cs

src/Cli/Program.cs

src/Cli.Tests/EndToEndTests.cs

src/Service/Startup.cs

Aniruddh25 · 2026-03-12T19:30:51Z

/azp run

azure-pipelines · 2026-03-12T19:31:16Z

Azure Pipelines successfully started running 6 pipeline(s).

src/Config/FileSystemRuntimeConfigLoader.cs

aaronburtle · 2026-03-12T20:20:10Z

Is the description up to date?

Added Program.PreParseLogLevel() — scans raw args[] for --LogLevel before CommandLine.Parser runs — so the logger factory is configured at the right level before any CLI-phase output is emitted.

I dont see these changes in the files, or was this renamed?

aaronburtle · 2026-03-12T20:37:35Z

CLI logger respects --LogLevel CustomConsoleLogger had a hardcoded _minimumLogLevel = LogLevel.Information, making it ignore the --LogLevel flag entirely.

How is the CustomConsoleLogger getting --loglevel? I think some changes were reverted and maybe the description isn't accurate anymore.

aaronburtle

Looks good once the description is fixed.

…l-incorrect-behavior' into copilot/fix-loglevel-incorrect-behavior

RubenCerna2079 · 2026-03-12T21:32:15Z

/azp run

azure-pipelines · 2026-03-12T21:32:39Z

Azure Pipelines successfully started running 6 pipeline(s).

aaronburtle

Looks good!

anushakolan · 2026-03-12T23:15:40Z

/azp run

azure-pipelines · 2026-03-12T23:16:04Z

Azure Pipelines successfully started running 6 pipeline(s).

Initial plan

d4ad8a3

Copilot AI assigned Copilot and RubenCerna2079 Mar 7, 2026

Copilot started work on behalf of RubenCerna2079 March 7, 2026 00:57 View session

Fix LogLevel incorrect behavior: CLI phase messages and case-insensit…

36bfd9a

…ive Default key Co-authored-by: RubenCerna2079 <32799214+RubenCerna2079@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix incorrect behavior of LogLevel~~ Fix LogLevel: CLI phase suppression and case-insensitive "Default" config key Mar 7, 2026

Copilot finished work on behalf of RubenCerna2079 March 7, 2026 01:19

RubenCerna2079 linked an issue Mar 9, 2026 that may be closed by this pull request

[Bug]: LogLevel incorrect behavior and failing #3201

Open

Aniruddh25 added the 2.0 label Mar 10, 2026

RubenCerna2079 and others added 3 commits March 11, 2026 17:06

Fix log level logic

6188dc7

Remove unnecessary code

ad13f1f

Merge branch 'main' into copilot/fix-loglevel-incorrect-behavior

caabc06

RubenCerna2079 marked this pull request as ready for review March 12, 2026 00:24

RubenCerna2079 requested review from Aniruddh25, JerryNixon, RubenCerna2079, aaronburtle, anushakolan and souvikghosh04 as code owners March 12, 2026 00:24

Copilot AI review requested due to automatic review settings March 12, 2026 00:24

RubenCerna2079 requested review from Alekhya-Polavarapu, rusamant, sourabh1007, stuartpa and vadeveka as code owners March 12, 2026 00:24

Copilot started reviewing on behalf of RubenCerna2079 March 12, 2026 00:25 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Add missing new classes

fe81966

anushakolan assigned aaronburtle Mar 12, 2026

RubenCerna2079 mentioned this pull request Mar 12, 2026

Refactor Log Level #3239

Open

RubenCerna2079 and others added 2 commits March 12, 2026 11:53

Make changes based on comments

bf9cfd7

Merge branch 'main' into copilot/fix-loglevel-incorrect-behavior

eb6b4fd

Aniruddh25 approved these changes Mar 12, 2026

View reviewed changes

Merge branch 'main' into copilot/fix-loglevel-incorrect-behavior

e1bc280

aaronburtle reviewed Mar 12, 2026

View reviewed changes

src/Config/FileSystemRuntimeConfigLoader.cs Outdated Show resolved Hide resolved

aaronburtle approved these changes Mar 12, 2026

View reviewed changes

RubenCerna2079 modified the milestone: March 2026 Mar 12, 2026

RubenCerna2079 added this to Data API builder Mar 12, 2026

github-project-automation bot moved this to Todo in Data API builder Mar 12, 2026

RubenCerna2079 removed this from Data API builder Mar 12, 2026

RubenCerna2079 added this to Data API builder Mar 12, 2026

github-project-automation bot moved this to Todo in Data API builder Mar 12, 2026

RubenCerna2079 and others added 3 commits March 12, 2026 14:31

Add helper method

1c85d6c

Merge branch 'main' into copilot/fix-loglevel-incorrect-behavior

88e235a

Merge remote-tracking branch 'refs/remotes/origin/copilot/fix-logleve…

5994db0

…l-incorrect-behavior' into copilot/fix-loglevel-incorrect-behavior

aaronburtle approved these changes Mar 12, 2026

View reviewed changes

RubenCerna2079 enabled auto-merge (squash) March 12, 2026 22:10

RubenCerna2079 disabled auto-merge March 12, 2026 22:13

Merge branch 'main' into copilot/fix-loglevel-incorrect-behavior

766aa35

Conversation

Copilot AI commented Mar 7, 2026 • edited by RubenCerna2079 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why make this change?

What is this change?

How was this tested?

Sample Request(s)

Uh oh!

RubenCerna2079 commented Mar 12, 2026

Uh oh!

azure-pipelines bot commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Aniruddh25 commented Mar 12, 2026

Uh oh!

azure-pipelines bot commented Mar 12, 2026

Uh oh!

Uh oh!

aaronburtle commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronburtle commented Mar 12, 2026

Uh oh!

aaronburtle left a comment

Choose a reason for hiding this comment

Uh oh!

RubenCerna2079 commented Mar 12, 2026

Uh oh!

azure-pipelines bot commented Mar 12, 2026

Uh oh!

aaronburtle left a comment

Choose a reason for hiding this comment

Uh oh!

anushakolan commented Mar 12, 2026

Uh oh!

azure-pipelines bot commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Copilot AI commented Mar 7, 2026 •

edited by RubenCerna2079

Loading

aaronburtle commented Mar 12, 2026 •

edited

Loading